https://bugzilla.redhat.com/show_bug.cgi?id=1421041 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- When linking to the spec file and srpm, link directly to the raw version (https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-gettext-tools.spec). Otherwise fedora-review gets confused. Why do you prefix your macros with "_"? Sometimes macros provided by rpm are prefixed with "__" to avoid conflicts with user-defined macros. That's even more reason not to prefix your macros like that. I'm assuming that this is an effort to get the whole package set into Fedora, not EPEL. If you are planning to use the same spec file also for EPEL, some things will be more complicated. My comments below assume that this is for Fedora only. > %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig This shouldn't be necessary, %python2_sitelib is always defined when the python2-devel is present. > - Package contains BR: python2-devel or python3-devel @Felix: it's better to link to the relevant guidelines more often than not. In this case: https://fedoraproject.org/wiki/Packaging:Python#Dependencies. > BuildRequires: python-devel ... this should be either python2-devel or python3-devel. Felix writes that Python3 is now supported. The guidelines say that Python3 is preferred, so the package should be switched to it if possible. > Requires: python Normally that's not needed, because the dependency is generated automatically. %description is too sparse. What does this package do? For "low level" packages it's OK to just write on or two terse sentences, but just repeating %summary is not enough, unless it's obvious (and in this case it's not obvious). OK, so Requires are not generated properly, because the shebang lines use #!/usr/bin/env. They should be changed to use #!/usr/bin/perl, #!%{__python2} or #!%{__python3}. Then rpm will generate proper Requires automatically. -- So... please update to the latest version, switch over to python3 if possible, expand %description, fix shebang lines, and let rpm generate Requires automatically. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
