https://bugzilla.redhat.com/show_bug.cgi?id=1421041 Felix Yan <felixonmars@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felixonmars@xxxxxxxxxxxxx --- Comment #1 from Felix Yan <felixonmars@xxxxxxxxxxxxx> --- > %global __requires_exclude ^perl The perl dependencies are actually used in /usr/bin/deepin-desktop-ts-convert. Without the tool some .desktop files in the related packages won't be generated. For example, /usr/share/applications/deepin-toggle-desktop.desktop won't be generated and the functionality will be missing from deepin-session-ui. > # fix python version Note that since version 1.0.6 Python 3.x is supported and the hack is no longer needed. The dependencies can be adjusted as wel. Others looks good at the moment. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2.1) LGPL (v2.1)", "GPL (v3 or later)", "Unknown or generated", "*No copyright* GPL". 128 files have unknown license. Detailed output of licensecheck in /home/felix/projects/fedora/fedora-staging/deepin-gettext-tools /review-deepin-gettext-tools/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/deepin-gettext-tools [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/deepin-gettext-tools [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: deepin-gettext-tools-1.0.4-1.git4303c4a.fc27.x86_64.rpm deepin-gettext-tools-1.0.4-1.git4303c4a.fc27.src.rpm deepin-gettext-tools.x86_64: E: no-binary deepin-gettext-tools.x86_64: W: only-non-binary-in-usr-lib deepin-gettext-tools.x86_64: W: no-documentation deepin-gettext-tools.x86_64: E: zero-length /usr/lib/deepin-gettext-tools/blank.py deepin-gettext-tools.x86_64: E: wrong-script-interpreter /usr/lib/deepin-gettext-tools/desktop_ts/desktop_ts_convert.pl /usr/bin/env perl deepin-gettext-tools.x86_64: E: wrong-script-interpreter /usr/lib/deepin-gettext-tools/generate_mo.py /usr/bin/env python2 deepin-gettext-tools.x86_64: E: wrong-script-interpreter /usr/lib/deepin-gettext-tools/update_pot.py /usr/bin/env python2 deepin-gettext-tools.x86_64: W: no-manual-page-for-binary deepin-desktop-ts-convert deepin-gettext-tools.x86_64: W: no-manual-page-for-binary deepin-generate-mo deepin-gettext-tools.x86_64: W: no-manual-page-for-binary deepin-update-pot deepin-gettext-tools.src:38: E: hardcoded-library-path in %{_prefix}/lib/%{name}/* 2 packages and 0 specfiles checked; 6 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- deepin-gettext-tools.x86_64: E: no-binary deepin-gettext-tools.x86_64: W: only-non-binary-in-usr-lib deepin-gettext-tools.x86_64: W: no-documentation deepin-gettext-tools.x86_64: E: zero-length /usr/lib/deepin-gettext-tools/blank.py deepin-gettext-tools.x86_64: E: wrong-script-interpreter /usr/lib/deepin-gettext-tools/desktop_ts/desktop_ts_convert.pl /usr/bin/env perl deepin-gettext-tools.x86_64: E: wrong-script-interpreter /usr/lib/deepin-gettext-tools/generate_mo.py /usr/bin/env python2 deepin-gettext-tools.x86_64: E: wrong-script-interpreter /usr/lib/deepin-gettext-tools/update_pot.py /usr/bin/env python2 deepin-gettext-tools.x86_64: W: no-manual-page-for-binary deepin-desktop-ts-convert deepin-gettext-tools.x86_64: W: no-manual-page-for-binary deepin-generate-mo deepin-gettext-tools.x86_64: W: no-manual-page-for-binary deepin-update-pot 1 packages and 0 specfiles checked; 5 errors, 5 warnings. Requires -------- deepin-gettext-tools (rpmlib, GLIBC filtered): /usr/bin/env gettext python Provides -------- deepin-gettext-tools: deepin-gettext-tools deepin-gettext-tools(x86-64) Source checksums ---------------- https://github.com/linuxdeepin/deepin-gettext-tools/archive/4303c4a4f2b4eed0744d16576fb2c0d09f54aa88/deepin-gettext-tools-4303c4a.tar.gz : CHECKSUM(SHA256) this package : 3f382400bcf7024426f421f1e4cf73ad133188b28cf5aec227ff5e07ccb05145 CHECKSUM(SHA256) upstream package : 3f382400bcf7024426f421f1e4cf73ad133188b28cf5aec227ff5e07ccb05145 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n deepin-gettext-tools Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++, Perl Disabled plugins: Java, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
