https://bugzilla.redhat.com/show_bug.cgi?id=1368855 --- Comment #14 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- This is not a formal review. Radare2 seems to be a bit of bundling nightmare to me; I'd think you'd need an exception for it, but I'm not too sure you'd get it. The custom build system also makes it difficult to say whether nothing is statically linked (because I'm too lazy atm), so I'd be much happier when they switch to Meson. Please run rpmlint on the spec, srpm, *and* the binary rpms. There are several trivial issues that could be fixed from that (also noted below.) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/radare2 See: https://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license is not marked as %license See: https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text Not sure why this comes up; maybe because it's not tagged in -devel? - Packaged files: * Bare .so files in in the main package; they should be -devel. * /usr/share/doc/radare2/bash_autocompletion.sh should probably be installed as a real completion file. * What are these /usr/share/doc/radare2/fortunes.* for? Not sure about the nsfw ones. Pretty sure the offensive entries in the real fortune-mod package are disabled. * Stuff like doc/crosscompile seem irrelevant. * Can the global magic database be used instead of /usr/share/radare2/1.4.0/magic? * Are the sdb files arch-independent? fedora-review suggests that the share/radare2 directory could be a separate non-arch package. * The /usr/bin/r2-indent and /usr/bin/r2-docker symlinks are broken. - Dependencies: * Needs a BuildRequires: gcc at least. The bundled tcc might also need a Requires as well. * zlib-devel should be added, I believe. * fedora-review complains about Perl; I'm not sure if it's used for the build or just an example, so I don't know if it should be required. - Group is not needed in Fedora packages any more. - I think the r2pm script should be patched to disallow global modifications if possible, or make sure to use something like /usr/local. This always ends up causing trouble with pip... - Extra comments should be removed. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [?]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v2) (with incorrect FSF address)", "*No copyright* CC0", "*No copyright* MPL (v2.0)", "BSD (3 clause)", "GPL (v1 or later)", "LGPL (v2 or later)", "GPL (v3 or later)", "zlib/libpng", "GPL (v2 or later) (with incorrect FSF address)", "BSD (2 clause)", "GPL (v3)", "GPL (v1 or later) (with incorrect FSF address)", "Apache (v2.0)", "GPL (v2 or later)", "LGPL (v3.0 or later)", "MIT/X11 (BSD like)", "BSD (3 clause) GPL (v3 or later)", "*No copyright* Public domain", "MPL (v1.1) GPL (v2 or later)", "BSD (unspecified)", "*No copyright* GPL LGPL", "LGPL", "Unknown or generated", "BSD (4 clause)", "NTP", "*No copyright* LGPL (v3)". 2042 files have unknown license. Detailed output of licensecheck in 1368855-radare2/licensecheck.txt [!]: License file installed when any subpackage combination is installed. No license in -devel package. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 276480 bytes in 83 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [?]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in radare2-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Patch is outdated and should be dropped. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 6533120 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: radare2-1.5.0-1.fc27.x86_64.rpm radare2-devel-1.5.0-1.fc27.x86_64.rpm radare2-debuginfo-1.5.0-1.fc27.x86_64.rpm radare2-1.5.0-1.fc27.src.rpm radare2.x86_64: W: name-repeated-in-summary C radare2 radare2.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti radare2.x86_64: W: spelling-error %description -l en_US scriptable -> scrip table, scrip-table, script able radare2.x86_64: W: spelling-error %description -l en_US opcode -> op code, op-code, code radare2.x86_64: E: invalid-soname /usr/lib64/libr_bp.so.1.5.0 libr_bp.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_lang.so.1.5.0 libr_lang.so radare2.x86_64: W: shared-lib-calls-exit /usr/lib64/libr_lang.so.1.5.0 exit@GLIBC_2.2.5 radare2.x86_64: E: invalid-soname /usr/lib64/libr_config.so.1.5.0 libr_config.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_egg.so.1.5.0 libr_egg.so radare2.x86_64: W: shared-lib-calls-exit /usr/lib64/libr_egg.so.1.5.0 exit@GLIBC_2.2.5 radare2.x86_64: E: invalid-soname /usr/lib64/libr_hash.so.1.5.0 libr_hash.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_util.so.1.5.0 libr_util.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_magic.so.1.5.0 libr_magic.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_bin.so.1.5.0 libr_bin.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_crypto.so.1.5.0 libr_crypto.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_asm.so.1.5.0 libr_asm.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_debug.so.1.5.0 libr_debug.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_cons.so.1.5.0 libr_cons.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_socket.so.1.5.0 libr_socket.so radare2.x86_64: E: missing-call-to-chdir-with-chroot /usr/lib64/libr_socket.so.1.5.0 radare2.x86_64: E: invalid-soname /usr/lib64/libr_syscall.so.1.5.0 libr_syscall.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_search.so.1.5.0 libr_search.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_fs.so.1.5.0 libr_fs.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_flag.so.1.5.0 libr_flag.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_io.so.1.5.0 libr_io.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_core.so.1.5.0 libr_core.so radare2.x86_64: W: shared-lib-calls-exit /usr/lib64/libr_core.so.1.5.0 exit@GLIBC_2.2.5 radare2.x86_64: E: invalid-soname /usr/lib64/libr_anal.so.1.5.0 libr_anal.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_reg.so.1.5.0 libr_reg.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_parse.so.1.5.0 libr_parse.so radare2.x86_64: W: shared-lib-calls-exit /usr/lib64/libr_parse.so.1.5.0 exit@GLIBC_2.2.5 radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_magic.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_egg.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_syscall.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_flag.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_crypto.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_config.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_util.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_anal.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_debug.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_core.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_bin.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_asm.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr2.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_reg.so radare2.x86_64: E: script-without-shebang /usr/share/radare2/1.5.0/www/enyo/vendors/jquery.min.js radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_search.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_bp.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_hash.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_cons.so radare2.x86_64: W: dangling-symlink /usr/bin/r2-indent /builddir/build/BUILD/radare2-1.5.0/sys/indent.sh radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_parse.so radare2.x86_64: W: dangling-symlink /usr/bin/r2-docker /builddir/build/BUILD/radare2-1.5.0/sys/r2-docker.sh radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_fs.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_io.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_socket.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_lang.so radare2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id radare2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id radare2.x86_64: W: no-manual-page-for-binary r2-indent radare2-devel.x86_64: W: only-non-binary-in-usr-lib radare2-devel.x86_64: W: no-documentation radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/tricore-opc.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/tricore-dis.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/sh/gnu/sh-opc.h radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/sh/gnu/sh-dis.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/include/opcode/tricore.h radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/hash/md4.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/cpu-tricore.c radare2.src: W: name-repeated-in-summary C radare2 radare2.src: W: spelling-error %description -l en_US multi -> mulch, mufti radare2.src: W: spelling-error %description -l en_US scriptable -> scrip table, scrip-table, script able radare2.src: W: spelling-error %description -l en_US opcode -> op code, op-code, code radare2.src:9: W: macro-in-comment %{shortcommit} radare2.src:40: W: macro-in-comment %{gituser} radare2.src:40: W: macro-in-comment %{gitname} radare2.src:40: W: macro-in-comment %{commit} radare2.src:40: W: macro-in-comment %{name} radare2.src:40: W: macro-in-comment %{version} radare2.src:40: W: macro-in-comment %{shortcommit} radare2.src:73: W: macro-in-comment %{gitname} radare2.src:73: W: macro-in-comment %{commit} radare2.src:75: W: macro-in-comment %patch0 radare2.src:83: W: macro-in-comment %check radare2.src:84: W: make-check-outside-check-section # make tests radare2.src: W: patch-not-applied Patch0: %{name}-capstone4.patch 4 packages and 0 specfiles checked; 31 errors, 55 warnings. Spelling errors are spurious; devel file should be moved as noted above. Comments and patches should be cleaned up. Symlinks need to be fixed. Rpmlint (debuginfo) ------------------- Checking: radare2-debuginfo-1.5.0-1.fc27.x86_64.rpm radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/cpu-tricore.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/include/opcode/tricore.h radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/sh/gnu/sh-opc.h radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/tricore-dis.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/tricore-opc.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/hash/md4.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/sh/gnu/sh-dis.c 1 packages and 0 specfiles checked; 7 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/include/opcode/tricore.h radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/sh/gnu/sh-dis.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/sh/gnu/sh-opc.h radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/cpu-tricore.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/tricore-dis.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/asm/arch/tricore/gnu/tricore-opc.c radare2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/radare2-1.5.0-1.fc27.x86_64/libr/hash/md4.c radare2-devel.x86_64: W: only-non-binary-in-usr-lib radare2-devel.x86_64: W: no-documentation radare2.x86_64: W: name-repeated-in-summary C radare2 radare2.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti radare2.x86_64: W: spelling-error %description -l en_US scriptable -> scrip table, scrip-table, script able radare2.x86_64: W: spelling-error %description -l en_US opcode -> op code, op-code, code radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libdl.so.2 radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_parse.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_search.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_cons.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_config.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_bin.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_debug.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_anal.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_reg.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_bp.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_io.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_lang.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_asm.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_syscall.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_hash.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_crypto.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_magic.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_socket.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_flag.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_egg.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libr_fs.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr2.so.1.5.0 /lib64/libutil.so.1 radare2.x86_64: E: invalid-soname /usr/lib64/libr_anal.so.1.5.0 libr_anal.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_asm.so.1.5.0 libr_asm.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_asm.so.1.5.0 /lib64/libr_lang.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_asm.so.1.5.0 /lib64/libr_cons.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_asm.so.1.5.0 /lib64/libr_reg.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_bin.so.1.5.0 libr_bin.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_bin.so.1.5.0 /lib64/libr_socket.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_bin.so.1.5.0 /lib64/libr_magic.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_bp.so.1.5.0 libr_bp.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_config.so.1.5.0 libr_config.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_cons.so.1.5.0 libr_cons.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_core.so.1.5.0 libr_core.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_core.so.1.5.0 /lib64/libdl.so.2 radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_core.so.1.5.0 /lib64/libr_magic.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_core.so.1.5.0 /lib64/libutil.so.1 radare2.x86_64: W: shared-lib-calls-exit /usr/lib64/libr_core.so.1.5.0 exit@GLIBC_2.2.5 radare2.x86_64: E: invalid-soname /usr/lib64/libr_crypto.so.1.5.0 libr_crypto.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_crypto.so.1.5.0 /lib64/libr_hash.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_debug.so.1.5.0 libr_debug.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_debug.so.1.5.0 /lib64/libr_parse.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_debug.so.1.5.0 /lib64/libutil.so.1 radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_debug.so.1.5.0 /lib64/libr_flag.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_debug.so.1.5.0 /lib64/libr_socket.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_egg.so.1.5.0 libr_egg.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_egg.so.1.5.0 /lib64/libr_parse.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_egg.so.1.5.0 /lib64/libr_reg.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_egg.so.1.5.0 /lib64/libr_anal.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_egg.so.1.5.0 /lib64/libr_flag.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_egg.so.1.5.0 /lib64/libr_cons.so radare2.x86_64: W: shared-lib-calls-exit /usr/lib64/libr_egg.so.1.5.0 exit@GLIBC_2.2.5 radare2.x86_64: E: invalid-soname /usr/lib64/libr_flag.so.1.5.0 libr_flag.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_fs.so.1.5.0 libr_fs.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_fs.so.1.5.0 /lib64/libr_io.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_hash.so.1.5.0 libr_hash.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_io.so.1.5.0 libr_io.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_io.so.1.5.0 /lib64/libutil.so.1 radare2.x86_64: E: invalid-soname /usr/lib64/libr_lang.so.1.5.0 libr_lang.so radare2.x86_64: W: shared-lib-calls-exit /usr/lib64/libr_lang.so.1.5.0 exit@GLIBC_2.2.5 radare2.x86_64: E: invalid-soname /usr/lib64/libr_magic.so.1.5.0 libr_magic.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_magic.so.1.5.0 /lib64/libr_util.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_parse.so.1.5.0 libr_parse.so radare2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libr_parse.so.1.5.0 /lib64/libr_cons.so radare2.x86_64: W: shared-lib-calls-exit /usr/lib64/libr_parse.so.1.5.0 exit@GLIBC_2.2.5 radare2.x86_64: E: invalid-soname /usr/lib64/libr_reg.so.1.5.0 libr_reg.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_search.so.1.5.0 libr_search.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_socket.so.1.5.0 libr_socket.so radare2.x86_64: E: missing-call-to-chdir-with-chroot /usr/lib64/libr_socket.so.1.5.0 radare2.x86_64: E: invalid-soname /usr/lib64/libr_syscall.so.1.5.0 libr_syscall.so radare2.x86_64: E: invalid-soname /usr/lib64/libr_util.so.1.5.0 libr_util.so radare2.x86_64: W: dangling-symlink /usr/bin/r2-docker /builddir/build/BUILD/radare2-1.5.0/sys/r2-docker.sh radare2.x86_64: W: dangling-symlink /usr/bin/r2-indent /builddir/build/BUILD/radare2-1.5.0/sys/indent.sh radare2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id radare2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr2.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_anal.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_asm.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_bin.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_bp.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_config.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_cons.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_core.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_crypto.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_debug.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_egg.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_flag.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_fs.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_hash.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_io.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_lang.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_magic.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_parse.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_reg.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_search.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_socket.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_syscall.so radare2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libr_util.so radare2.x86_64: E: script-without-shebang /usr/share/radare2/1.5.0/www/enyo/vendors/jquery.min.js radare2.x86_64: W: no-manual-page-for-binary r2-indent 3 packages and 0 specfiles checked; 31 errors, 82 warnings. Requires -------- radare2-debuginfo (rpmlib, GLIBC filtered): radare2-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config radare2(x86-64) radare2 (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig libc.so.6()(64bit) libcapstone.so.3()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libmagic.so.1()(64bit) libpthread.so.0()(64bit) libr2.so.1.5.0()(64bit) libr_anal.so()(64bit) libr_asm.so()(64bit) libr_bin.so()(64bit) libr_bp.so()(64bit) libr_config.so()(64bit) libr_cons.so()(64bit) libr_core.so()(64bit) libr_crypto.so()(64bit) libr_debug.so()(64bit) libr_egg.so()(64bit) libr_flag.so()(64bit) libr_fs.so()(64bit) libr_hash.so()(64bit) libr_io.so()(64bit) libr_lang.so()(64bit) libr_magic.so()(64bit) libr_parse.so()(64bit) libr_reg.so()(64bit) libr_search.so()(64bit) libr_socket.so()(64bit) libr_syscall.so()(64bit) libr_util.so()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) Provides -------- radare2-debuginfo: radare2-debuginfo radare2-debuginfo(x86-64) radare2-devel: pkgconfig(r_anal) pkgconfig(r_asm) pkgconfig(r_bin) pkgconfig(r_bp) pkgconfig(r_config) pkgconfig(r_cons) pkgconfig(r_core) pkgconfig(r_debug) pkgconfig(r_flag) pkgconfig(r_fs) pkgconfig(r_hash) pkgconfig(r_io) pkgconfig(r_lang) pkgconfig(r_magic) pkgconfig(r_parse) pkgconfig(r_reg) pkgconfig(r_search) pkgconfig(r_socket) pkgconfig(r_syscall) pkgconfig(r_util) radare2-devel radare2-devel(x86-64) radare2: libr2.so.1.5.0()(64bit) libr_anal.so()(64bit) libr_asm.so()(64bit) libr_bin.so()(64bit) libr_bp.so()(64bit) libr_config.so()(64bit) libr_cons.so()(64bit) libr_core.so()(64bit) libr_crypto.so()(64bit) libr_debug.so()(64bit) libr_egg.so()(64bit) libr_flag.so()(64bit) libr_fs.so()(64bit) libr_hash.so()(64bit) libr_io.so()(64bit) libr_lang.so()(64bit) libr_magic.so()(64bit) libr_parse.so()(64bit) libr_reg.so()(64bit) libr_search.so()(64bit) libr_socket.so()(64bit) libr_syscall.so()(64bit) libr_util.so()(64bit) radare2 radare2(x86-64) Unversioned so-files -------------------- radare2: /usr/lib64/libr2.so radare2: /usr/lib64/libr_anal.so radare2: /usr/lib64/libr_asm.so radare2: /usr/lib64/libr_bin.so radare2: /usr/lib64/libr_bp.so radare2: /usr/lib64/libr_config.so radare2: /usr/lib64/libr_cons.so radare2: /usr/lib64/libr_core.so radare2: /usr/lib64/libr_crypto.so radare2: /usr/lib64/libr_debug.so radare2: /usr/lib64/libr_egg.so radare2: /usr/lib64/libr_flag.so radare2: /usr/lib64/libr_fs.so radare2: /usr/lib64/libr_hash.so radare2: /usr/lib64/libr_io.so radare2: /usr/lib64/libr_lang.so radare2: /usr/lib64/libr_magic.so radare2: /usr/lib64/libr_parse.so radare2: /usr/lib64/libr_reg.so radare2: /usr/lib64/libr_search.so radare2: /usr/lib64/libr_socket.so radare2: /usr/lib64/libr_syscall.so radare2: /usr/lib64/libr_util.so radare2: /usr/lib64/radare2/1.5.0/asm_LM32.so radare2: /usr/lib64/radare2/1.5.0/asm_propeller.so radare2: /usr/lib64/radare2/1.5.0/bin_xtr_dyldcache.so radare2: /usr/lib64/radare2/1.5.0/parse_z80_pseudo.so Source checksums ---------------- https://github.com/radare/radare2/archive/1.5.0.tar.gz#/radare2-1.5.0.tar.gz : CHECKSUM(SHA256) this package : c6b465cb2f36a206d5e9380c0bcbb4c05ed5cb7995e554703206e0bbdc9c74a1 CHECKSUM(SHA256) upstream package : c6b465cb2f36a206d5e9380c0bcbb4c05ed5cb7995e554703206e0bbdc9c74a1 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -n radare2 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++, Perl Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
