https://bugzilla.redhat.com/show_bug.cgi?id=1468766 --- Comment #3 from Michael Cronenworth <mike@xxxxxxxxxx> --- (In reply to Ben Rosser from comment #1) > Issues: > ======= > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 110735360 bytes in 2808 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation The documentation is API documentation. The guidelines specifically state "For example API documentation belongs in the -devel subpackage, not the main one.", which is what occurs here. Now, large documentation is recommended to a sub-package (keyword: recommended), but it is still API documentation. I'll create a -devel-docs subpackage. > > - According to licensecheck, tinyxml sources appear to be bundled: > > zlib/libpng > ----------- > openzwave-1.4.164/cpp/tinyxml/tinyxml.cpp > openzwave-1.4.164/cpp/tinyxml/tinyxml.h > openzwave-1.4.164/cpp/tinyxml/tinyxmlerror.cpp > openzwave-1.4.164/cpp/tinyxml/tinyxmlparser.cpp > > Please either unbundle and remove these files if they're not necessary, or > add the appropriate Bundled provides and modify the License field > accordingly > to "LGPLv3+ and zlib" > > (https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging: > Bundled_Libraries) The example program uses tinyxml and not the library itself. I've removed the compiling pieces and linked the example program against the system library. > > - Binaries don't appear to be getting built with all hardening enabled: Fixed. > - In a similar vein, it looks as if you haven't enabled parallel build in > make. > Is there a reason for this? Deficiency from the upstream spec file this review originated from. > - rpmlint warning: > libopenzwave.x86_64: W: shared-lib-calls-exit > /usr/lib64/libopenzwave.so.1.4 exit@GLIBC_2.2.5 > This should probably be investigated and reported upstream. The code is doing the opposite of what it describes... I've patched it and will report upstream. New spec: http://michael.cronenworth.com/RPMS/openzwave.spec New SRPM: http://michael.cronenworth.com/RPMS/openzwave-1.4.164-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
