https://bugzilla.redhat.com/show_bug.cgi?id=1467322 --- Comment #7 from Adam Miller <admiller@xxxxxxxxxx> --- (In reply to Josh Boyer from comment #6) > (In reply to Adam Miller from comment #5) > > Thanks for picking up the review! > > > ITEMS TO FIX > > ------------ > > > > - All bundled golang libraries need to be listed as 'Provides: > > bundled(<libname>) = <version>' directives as per > > https://fedoraproject.org/wiki/Packaging: > > Guidelines#Bundling_and_Duplication_of_system_libraries > > > > Other than that, the package looks good. > > OK, so I have two questions: > > 1) Why do e.g. runc, docker, etc not Provide anything they bundle? Confused > there. I see stuff in -devel, but not in the main packages. > runc and docker should and if they aren't, they are in violation of the Guidelines, should have bugs filed against them, and should be fixed. > 2) An example of a Provide for this package would be: > > Provides: bundled(golang(github.com/codegangsta/cli/)) = v1.2.0 > Provides: bundled(golang(golang.org/x/net)) = master > > correct? The first one looks good pending that is a git tag that can be checked out, the latter however needs to correlate to a commit id or tag. For an examples, check the OpenShift Origin and/or reg specs: http://pkgs.fedoraproject.org/cgit/rpms/reg.git/tree/reg.spec http://pkgs.fedoraproject.org/cgit/rpms/origin.git/tree/origin.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
