[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1467322



--- Comment #6 from Josh Boyer <jwboyer@xxxxxxxxxx> ---
(In reply to Adam Miller from comment #5)

Thanks for picking up the review!

> ITEMS TO FIX
> ------------
> 
> - All bundled golang libraries need to be listed as 'Provides:
> bundled(<libname>) = <version>' directives as per
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#Bundling_and_Duplication_of_system_libraries
> 
> Other than that, the package looks good.

OK, so I have two questions:

1) Why do e.g. runc, docker, etc not Provide anything they bundle?  Confused
there.  I see stuff in -devel, but not in the main packages.

2) An example of a Provide for this package would be:

Provides: bundled(golang(github.com/codegangsta/cli/)) = v1.2.0
Provides: bundled(golang(golang.org/x/net)) = master

correct?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux