https://bugzilla.redhat.com/show_bug.cgi?id=1467129 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: [x] Follows general Fedora packaging guidelines [x] Package is named appropriately per Python packaging guidelines [x] License is marked correctly, and license file is included as %license file Looks good to me. There's only one thing... SHOULD FIX (on import): [!] %{py2_build} -> %py2_build. For the sake of clarity, command macros should not be wrapped in braces. Especially when they actually *can* accept parameters. Otherwise, package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
