https://bugzilla.redhat.com/show_bug.cgi?id=1467995 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Approved! I have two suggestions for improvement, but they are optional so feel free to ignore: 136 [!]: It would be nice to package the docs/ folder. I have no idea how they 137 are intended to be built, but you could just package the rst files 138 since rst is pretty human readable. 139 [!]: It'd be reasonable to drop the shebang on the _client.py file to get 140 rid of the rpmlint errors. You could also run dos2unix on the 141 README.rst to fix its line endings. If you have some time and wouldn't mind doing a review for me, I could use review on this one: https://bugzilla.redhat.com/show_bug.cgi?id=1467417 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
