https://bugzilla.redhat.com/show_bug.cgi?id=1250025 --- Comment #7 from Augusto Caringi <acaringi@xxxxxxxxxx> --- Package Review ============== MUST * Package contains no bundled libraries without FPC exception. There are 2 third-party libraries in the source tarball: gtest and fbson gtest is probably only needed for tests and is being removed in %prep. fbson is used (It's a C++ header-only library), just to mention because I think that there isn't much we can do about it. SHOULD * Latest version is packaged: Upstream seems to be very active and is releasing very often, the latest version is 5.4.6 (https://github.com/facebook/rocksdb/releases). * Package should compile and build into binary rpms on all supported architectures: On F25 i686 gcc hangs during compilation (maybe a bug in gcc), On F26 i686 and F27 i686 the compilation is successful. * %check is present and all tests pass: There is a test suite, but 'make check' needs recompilation in debug mode. * Reviewer should test that the package builds in mock: Yes, except for F25 i686 (compilation hangs) * Uses parallel make %{?_smp_mflags} macro: Yes, but this option has no effect due to a problem in the Makefile (Explanation in a previous comment). Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated", "*No copyright* Apache (v2.0)". 1072 files have unknown license. Detailed output of licensecheck in /home/acaringi/reviews/1250025-rocksdb/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. There are 2 thirdy-party libraries in the source tarball: gtest and fbson gtest is probably only needed for tests and are being removed in spec file. fbson is used (It's a C++ header-only library) [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rocksdb- debuginfo [?]: Package functions as described. [!]: Latest version is packaged. Upstream seems very active and releasing very often, the latest version is 5.4.6 [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. Scratch build in koji worked without any problem. [?]: %check is present and all tests pass. make check needs recompilation in debug mode. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rocksdb-5.2.1-1.fc25.x86_64.rpm rocksdb-devel-5.2.1-1.fc25.x86_64.rpm rocksdb-debuginfo-5.2.1-1.fc25.x86_64.rpm rocksdb-5.2.1-1.fc25.src.rpm rocksdb.x86_64: W: spelling-error %description -l en_US multithreaded -> multicolored rocksdb.x86_64: W: shared-lib-calls-exit /usr/lib64/librocksdb.so.5.2.1 exit@GLIBC_2.2.5 rocksdb.x86_64: W: no-documentation rocksdb-devel.x86_64: W: only-non-binary-in-usr-lib rocksdb-devel.x86_64: W: no-documentation rocksdb.src: W: spelling-error %description -l en_US multithreaded -> multicolored 4 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: rocksdb-debuginfo-5.2.1-1.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- rocksdb.x86_64: W: spelling-error %description -l en_US multithreaded -> multicolored rocksdb.x86_64: W: shared-lib-calls-exit /usr/lib64/librocksdb.so.5.2.1 exit@GLIBC_2.2.5 rocksdb.x86_64: W: no-documentation rocksdb-devel.x86_64: W: only-non-binary-in-usr-lib rocksdb-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- rocksdb (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) rtld(GNU_HASH) rocksdb-devel (rpmlib, GLIBC filtered): librocksdb.so.5.2()(64bit) rocksdb(x86-64) rocksdb-debuginfo (rpmlib, GLIBC filtered): Provides -------- rocksdb: librocksdb.so.5.2()(64bit) rocksdb rocksdb(x86-64) rocksdb-devel: rocksdb-devel rocksdb-devel(x86-64) rocksdb-debuginfo: rocksdb-debuginfo rocksdb-debuginfo(x86-64) Source checksums ---------------- https://github.com/facebook/rocksdb/archive/v5.2.1.tar.gz#/rocksdb-5.2.1.tar.gz : CHECKSUM(SHA256) this package : cb27afeaa3dea4369e7b982ce336c16ec2848879e7275043b94e9b42570158ec CHECKSUM(SHA256) upstream package : cb27afeaa3dea4369e7b982ce336c16ec2848879e7275043b94e9b42570158ec Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1250025 Buildroot used: fedora-25-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
