[Bug 1250025] Review Request: rocksdb - A Persistent Key-Value Store for Flash and RAM Storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1250025



--- Comment #6 from Augusto Caringi <acaringi@xxxxxxxxxx> ---
The build time is unusual long given the size of the software... More than 6
minutes on my machine.

The cause is that the Makefile has a problem and as a consequence it doesn't
use parallel jobs in the building process (even with the proper utilization of
%{?_smp_mflags} in the spec file).

This problem is already fixed in the upstream master branch...

Here is the complete explanation:

"Previously, the shared library (make shared_lib) was built with only one
compile line, compiling all .cc files and linking the shared library in
one step. That step would often take 10+ minutes on one machine, and
could not take advantage of multiple CPUs (it's only one invocation of
the compiler). This commit changes the shared_lib build to compile .o files
individually (placing the resulting .o files in the directory
shared-objects) and then link them into the shared library at the end,
similarly to how the java static build (jls) does it."

https://github.com/facebook/rocksdb/pull/2165

Maybe would be a good idea to apply this patch downstream...

On my machine the building time was cut by more than half.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux