https://bugzilla.redhat.com/show_bug.cgi?id=1462983 --- Comment #4 from Jeremy Cline <jeremy@xxxxxxxxxx> --- Thanks for the reviews! > Remove `v` from `%{name}-v%{version}.tar.gz` in Source0. Fancy, I assumed GitHub would get upset by this because the tag has a v in it, but it does the right thing! > Remove shebang from util.py: Done. An easier sed for this is ``sed -ie '1d' python/%{pypi_name}/util.py`` - I learned this from a different specfile yesterday :) > %files contains *, should be good if * is replaced with module_name I compromised here and included the module explicitly and specified the egg-info separately. > use python2-%{pypi_name} instead of python[23]-phonenumbers for consistency Good catch, fixed. > use {} arond variables like __python --> %{__python} for consistency Also fixed. Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20078244 SRPM URL: https://jcline.fedorapeople.org/python-phonenumbers-8.5.1-2.fc27.src.rpm Spec URL: https://jcline.fedorapeople.org/python-phonenumbers.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
