[Bug 1462983] Review Request: python-phonenumbers - A Python port of Google's libphonenumber

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1462983



--- Comment #3 from Filip Szymański <filip.szymanski@xxxxxxx> ---
(In reply to Yatin Karel from comment #2)

> 1) - %files contains *, should be good if * is replaced with module_name
`*` captures both the module directory and the egg-info directory, see:
https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Egg_Metadata_Using_Setuptools

> 2) - use python2-%{pypi_name} instead of python[23]-phonenumbers for
> consistency
Yes

> 3) use {} arond variables like __python --> %{__python} for consistency
Yes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux