https://bugzilla.redhat.com/show_bug.cgi?id=1455886 --- Comment #2 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> --- (In reply to Vít Ondruch from comment #1) > Just two quick notes moment: > > 1) I am not sure whether the "Recommends: flash-plugin" is legit, i.e. if > you can reference 3rd party repositories. You should probably consult this > with some ML (legal?, packaging?, devel?). I have started a discussion on the packaging forum [3]. > > 2) Since this is add-on package, it should contain add-on metadata [1]. This > way, Gnome Software will be able to list this add-on side by side with > Nuvola player, which is pretty convenient. > > > [1]: > https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation I added a metainfo.xml file to the spec file. Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-amazon-cloud-player.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-amazon-cloud-player-5.4-2.fc25.src.rpm %changelog * Fri May 26 2017 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 5.4-2 - Add %%{name}.metainfo.xml file - Add BR libappstream-glib [3] https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/thread/RIYNP4CERE3VZ3TLPSOQQJVNHJMG7EYC/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
