https://bugzilla.redhat.com/show_bug.cgi?id=1455886 --- Comment #1 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Just two quick notes moment: 1) I am not sure whether the "Recommends: flash-plugin" is legit, i.e. if you can reference 3rd party repositories. You should probably consult this with some ML (legal?, packaging?, devel?). 2) Since this is add-on package, it should contain add-on metadata [1]. This way, Gnome Software will be able to list this add-on side by side with Nuvola player, which is pretty convenient. [1]: https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
