https://bugzilla.redhat.com/show_bug.cgi?id=1368855 --- Comment #12 from Michael Scherer <misc@xxxxxxxx> --- > No it should not be dropped, otherwise the files, which are installed there by > the radare2 during the installation would be treated as installed, but > unpackaged. I know that some upstream do that, but that mean this will be broken (or rather, not coherent) if %_docdir_fmt is changed, like on EL, where the value is %{NAME}-%{VERSION} while on Fedora, that's %{NAME}. Hardcoding "%{_datadir}/doc/%{name}" is not correct (even if in practice, it would likely work). > I have tried to list the original licenses, but anyway due to theviral nature > of GPL I believe that as the original project released all those with GPL-ed > project, these are probably GPL-ed as well. That's not my understanding of the guidelines, as it clearly say all licenses must be listed in the tag, and I am sure that we should stick to it when it come to licensing. The comments can't be queried in case of problem with one license or anything, and I think that's the main use of that tag. Or it can be used to verify that all licenses text that requires to be included are included in the rpm, as that's a requirement from both the GPL, the LGPL and the Apache License 2.0. Speaking of that, the text of the Apache 2 license is missing from the package, since there is only GPL v3 and LGPL. That's a issue upstream, but technically, that's a license violation (as that's one of the few requirements of the Apache 2.0 license) Also, there is a few small error in the spec: # shlr/zip/zlib - 3 clause BSD (system installed sared zlib is used instead) => shared ? # shlr/www/enyo/vendors/jquery.min.js - Aplache License version 2.0 Apache ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
