https://bugzilla.redhat.com/show_bug.cgi?id=1449882 --- Comment #11 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Thanks for the changes! > Considering that section containing that old version of SRGB is only > intended for testing within %check, is there an alternative approach to > replace it with the one from colord? I see 3 alternatives here: 1) Remove the bad file from the sources and do not run tests that use the file in %check. 2) Remove the bad file from the sources, add the one with the good license and run the tests with it (it would be nice to send such patch upstream) 3) wait an upstream action before going on with this review. Now, It's up to you to pick one of those or propose some other solution. If you are going with 1 or 2, remember that you need to remove the bad file from the tarball, before even generating a srpm. Here are 2 nice examples of how you can accomplish that: [1], [2]. [1] https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code [2] http://pkgs.fedoraproject.org/cgit/rpms/calibre.git/tree/getsources.sh -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
