https://bugzilla.redhat.com/show_bug.cgi?id=1449882 --- Comment #10 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- (In reply to Athos Ribeiro from comment #9) > Hi Luya, > > The package builds correctly now, thanks for the modification. > > - Upstream ships the full GPLv3 licence text in the GPLv3.txt file, it would > be nice to ship it as well. The content in the LICENSE file is just the GPL > copying permission statement. Fixed. > - You should now remove the %clean section from the spec file [1]. Done > - rpmlint complains about mixed usage of spaces and tabs in the spec file > (lines 12 and 14 use tabs and the rest of the spec file uses spaces). Fixed > - There are .icm files in testdata dir. One of them is tagged as Public > Domain and the other one is under a HP copyright, are they both also > licensed as GPLv3 [2]? Do you have any comments on those? Public Domain should be ok as permitted license. Only that old version of sRGB is not permitted according to the License guideline (https://fedoraproject.org/wiki/Licensing:Main#Bad_Licenses). I filed a upstream report to request a change replacing that icm with a FSF compatible which is already available on http://www.color.org/srgbprofiles.xalter. See https://github.com/sk1project/python-lcms2/issues/1 Considering that section containing that old version of SRGB is only intended for testing within %check, is there an alternative approach to replace it with the one from colord? Updated specs: Here is the updated specs Spec URL: https://luya.fedorapeople.org/packages/SPECS/python-lcms2.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/python-lcms2-0.1-4.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
