https://bugzilla.redhat.com/show_bug.cgi?id=1372866 --- Comment #36 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- One more nitpick: I suggested: > https://github.com/01org/hyperscan/archive/%{version}.tar.gz#/hyperscan-%{version}.tar.gz That doesn't work, because I forgot a "v". It should have been https://github.com/01org/hyperscan/archive/v%{version}.tar.gz#/hyperscan-%{version}.tar.gz You used: > https://github.com/01org/%{name}/archive/%{gittag0}.tar.gz#/%{name}-%{version}.tar.gz That works, but it uses both gittag0 and version. That is suboptimal because you need to change both gittag0 and version when updating version. What's worse, if you forget one, you'll get a mismatched tarball name and contents. So I'd suggest using %{version} or "v%{version}" everywhere instead of %{gittag0} and removing %gittag0 definition completely. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
