https://bugzilla.redhat.com/show_bug.cgi?id=1372866 --- Comment #35 from Jason Taylor <jtfas90@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #34) > (In reply to Jason Taylor from comment #33) > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #32) > > > You should provide a symlink to the spec file and srpm file directly in > > > comments, so that fedora-review can find them: > > > spec file: https://jtaylor.fedorapeople.org/hyperscan/hyperscan.spec > > > srpm: > > > https://jtaylor.fedorapeople.org/hyperscan/hyperscan-4.4.1-1.fc27.src.rpm > > > > srpm: > > https://jtaylor.fedorapeople.org/hyperscan/hyperscan-4.4.1-2.fc27.src.rpm > > spec file: https://jtaylor.fedorapeople.org/hyperscan/hyperscan.spec > > > > latest scratch build: > > https://koji.fedoraproject.org/koji/taskinfo?taskID=19507079 > > > > > > https://github.com/01org/%{name}/archive/%{gittag0}.tar.gz#/%{gittag0}.tar.gz > > > This isn't useful — you are renaming the tarball to the original (bad) name. > > > You want ...#/hyperscan-%{gittag0}.tar.gz > > > > Updated > Hm, you removed the renaming completely. While not strictly required, its > recommended to make the tarball more recognizable. So you want something > like this: > > Source0: > https://github.com/01org/hyperscan/archive/%{version}.tar.gz#/hyperscan- > %{version}.tar.gz > > (or Source0: > https://github.com/01org/%{name}/archive/%{version}.tar.gz#/%{name}- > %{version}.tar.gz is you like macros a lot) Oh, I see. Thank you for the explanation! I updated the spec: https://jtaylor.fedorapeople.org/hyperscan/hyperscan.spec Does that work? > But that's just cosmetic. I think you should go ahead with the build, any > issues can be tweaked later. Great thank you for the help! JT -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
