https://bugzilla.redhat.com/show_bug.cgi?id=1441046 --- Comment #8 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Luya Tshimbalanga from comment #7) > > > swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py /usr/bin/env python > > > > Please fix. You can find an example here: > > > > http://pkgs.fedoraproject.org/cgit/rpms/python-rfc3987.git/tree/python- > > rfc3987.spec#n55 > > Looking at the tip part: > https://fedoraproject.org/wiki/Packaging_tricks?rd=PackageMaintainers/ > Packaging_Tricks#Remove_shebang_from_Python_libraries > > How to properly substitute "/usr/bin/env python" with "!/usr/bin/python"? I > currently use > > # Remove shebang > for lib in %{buildroot}%{python_sitelib}/swatchbook/*/*.py; do > sed '1{\@^#!/usr/bin/env python@d}' $lib > $lib.new && > touch -r $lib $lib.new && > mv $lib.new $lib > done > > but rpmlint keeps on complaining > > swatchbooker.noarch: E: script-without-shebang > /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_soc.py > > > > swatchbooker.noarch: E: non-executable-script > > /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py 644 /usr/bin/env > > python > > > > Sorry, also this, make sure all .py files are 755. > > Done Ok, so I misinterpreted all of this, my bad. This is due to the fact that rpmlint was getting .py as script files and marking them as non executable. Library files (basically /usr/share/swatchbooker/*) should NOT have the shebang at the top and should NOT be marked as executables. So what you did is correct, but my comment about marking them as 755 was wrong. For main executables, make sure there you have a shebang and the interpreter should be !#/usr/bin/python. Just check with rpmlint after you're finished rebuilding so that the errors are silenced. After finishing this, I think the package can be approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
