https://bugzilla.redhat.com/show_bug.cgi?id=1441046 --- Comment #7 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- (In reply to Simone Caronni from comment #5) > > [!]: Package requires other packages for directories it uses. > > Note: No known owner of /usr/lib/swatchbooker > > [!]: Package must own all directories that it creates. > > Note: Directories without known owners: /usr/lib/swatchbooker > > > swatchbooker.src:90: E: hardcoded-library-path in %{_prefix}/lib/%{name}/* > ...(snip)... > But you need to make sure that the python files are placed in > /usr/share/swatchbooker and that the %files section just selects that: > > %{_datadir}/%{name} Done > > > swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py /usr/bin/env python > > Please fix. You can find an example here: > > http://pkgs.fedoraproject.org/cgit/rpms/python-rfc3987.git/tree/python- > rfc3987.spec#n55 Looking at the tip part: https://fedoraproject.org/wiki/Packaging_tricks?rd=PackageMaintainers/Packaging_Tricks#Remove_shebang_from_Python_libraries How to properly substitute "/usr/bin/env python" with "!/usr/bin/python"? I currently use # Remove shebang for lib in %{buildroot}%{python_sitelib}/swatchbook/*/*.py; do sed '1{\@^#!/usr/bin/env python@d}' $lib > $lib.new && touch -r $lib $lib.new && mv $lib.new $lib done but rpmlint keeps on complaining swatchbooker.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_soc.py > > > %global commit c5c8b021c8f9420c26c11372c95a4a6f440dcc97 > > %global shortcommit %(c=%{commit}; echo ${c:0:7}) > > %global date 20170131 > > Release: 0.1%{?date:.%{date}git}%{?dist} > > This does not express the short git commit in the release field: > > https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots > > Please also use commit0/shortcommit0. For example: > > %global commit0 c5c8b021c8f9420c26c11372c95a4a6f440dcc97 > %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) > %global date 20170131 > Release: 0.1%{?shortcommit0:.%{date}git%{shortcommit0}}%{?dist} > > You can also check with %{?date} though, like you did. Done > > Optional: > > 1) Sort BuildRequires, one per line Done > 2) Have you considered building for both Python 2 and 3 in the same SPEC > file if supported by upstream? I tried that method which failed due to upstream only using Python 2 therefore unversionned python macros are a better options as you suggested. > > swatchbooker.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py 644 /usr/bin/env > python > > Sorry, also this, make sure all .py files are 755. Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
