[Bug 1444615] Review Request: python2-ipython - An enhanced interactive Python shell (Python 2 version)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1444615



--- Comment #5 from Lumír Balhar <lbalhar@xxxxxxxxxx> ---
> [!]: License file installed when any subpackage combination is installed.

File COPYING.rst from source tarball added to all subpackages.

> [!]: If the package is under multiple licenses, the licensing breakdown
>      must be documented in the spec.

Based on documentation and COPYING.rst, I changed the license to BSD.

> [!]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.
>      Note: I believe provides and obsoletes for "ipython" are missing.

Added
Obsoletes:      %{pypi_name} < 5.3.0-4
Provides:       %{pypi_name} = %{version}-%{release}

> [!]: Requires correct, justified where necessary.
>      Note: Use python2-backports-shutil_get_terminal_size, python2-ipython,
> python2-jsonschema, python2-path and python2-traitlets in (Build)Requires
> instead of python-***; python2-pathlib and python2-mistune are not yet
> available, so keep python-*** here

Fixed

> [!]: Avoid bundling fonts in non-fonts packages.
>      Note: Package contains font files

Fonts removed from doc subpackage.

> [!]: Package does not include license text files separate from upstream.

Fixed

> [!]: Patches link to upstream bugs/comments/lists or are otherwise
>      justified.
>      Note: Add link to Patch0.

Added link to PR (mentioned here) to specfile.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux