https://bugzilla.redhat.com/show_bug.cgi?id=1444518 Iwicki Artur <iwicki.artur@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iwicki.artur@xxxxxxxxxx --- Comment #1 from Iwicki Artur <iwicki.artur@xxxxxxxxxx> --- I am not a packager, so this is not an official review. I noticed the %files section uses > %{_datadir}/man/man5/coap*.gz The wiki page says you should not assume that gzip is used, and use a pattern which reflects that. Also, you may use %{_mandir} instead of %{_datadir}/man. https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages As a minor note, the %descriptions for -devel and -docs use the %{name} macro, whereas the -utils subpackage uses a bare string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx