[Bug 1440704] Review Request: cpprest - C++ REST SDK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1440704



--- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> ---
The Fedora Project does a couple of packaging related things differently than
whatever distribution you've used before. Here's the result of a brief look at
the spec file.

Consider pointing the fedora-review tool at this ticket:

  fedora-review -b 1440704

It will evaluate the latest "Spec URL:" and "SRPM URL:" lines, download the
files and packages, perform local test-builds in Mock and run many checks on
the packages. The tool is relevant to package submitters, too.


> Patch0: cpprest-pthread.patch

https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines


> %package devel
> Summary:        Development files for %{name}
> Requires:       libcpprest%{major}_%{minor} = %{version}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %files -n libcpprest%{major}_%{minor}
> %defattr(-,root,root)
> %doc CONTRIBUTORS.txt license.txt ThirdPartyNotices.txt
> %{_libdir}/libcpprest.so.%{major}.%{minor}
> %{_libdir}/libcpprest.so

https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages


> %defattr(-,root,root)

https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


> %package -n libcpprest%{major}_%{minor}

The naming of this subpackage is odd. What have you planned for updates that
touch %major or %minor or both?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux