https://bugzilla.redhat.com/show_bug.cgi?id=1441729 --- Comment #4 from greg.hellings@xxxxxxxxx --- Summary of issues. Some of them have more details below in the output of the tools. [!] Looks like there is a bundled external library in external/crcutil-1.0, which I don't find anywhere being packaged for Fedora. This should either be packaged separately or removed from the code tree before building, in order to ensure that it is not being built into this package. It looks like some code is lifted from Boost as well. Potentially from other places, as well, although tracing the exact pedigree of individual files can be difficult. The state of such bundled files should be clearly defined. [!] Licensing looks like it needs some clarifications to me. See below for more details on that. [!] /etc/mfs doesn't have anything taking ownership of it [!] You're running an unnecessary rm -rf %{buildroot} at the start of %install. This is obsolete and no longer needed [!] Use of %define instead of %global to set common variables throughout the package [!] rpmlint output is mostly innocuous, but the errors relate to the sed commands I asked you to update the previous round. Those macros only get defined if there is a BR on python-devel and python3-devel. I'll leave it up to your judgment whether you want to include those packages for the sake of the macros or if you want to revert to the hard-coded values. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSL (v1.0)", "*No copyright* GPL (v3 or later)", "*No copyright* GPL (v3)", "GPL (v2 or later) (with incorrect FSF address)", "BSD (3 clause)", "GPL (v3)", "*No copyright* Apache (v2.0)". 415 files have unknown license. There's lots of confusion about the licensing in these files, making it unclear where some of it all comes from. Some of these the tools picked up as being under a license that requires the license itself be distributed with the application. Some of those make me think they were lifted from partially bundled libraries (e.g. common/coroutine.h references being under the Boost license and is similar to some names files that came out of that library) [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/mfs One of these packages should take ownership of /etc/mfs [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/mfs [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. The following config files have supporting reason why stated in package Note: No (noreplace) in %config /etc/mfs/mfsexports.cfg.dist %config /etc/mfs/mfstopology.cfg.dist %config /etc/mfs/mfsgoals.cfg.dist %config /etc/mfs/mfsmaster.cfg.dist %config /etc/mfs/globaliolimits.cfg.dist %config /etc/mfs/mfsmetalogger.cfg.dist %config /etc/mfs/mfschunkserver.cfg.dist %config /etc/mfs/mfshdd.cfg.dist %config /etc/mfs/mfsmount.cfg.dist %config /etc/mfs/iolimits.cfg.dist [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 286720 bytes in 21 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lizardfs-master , lizardfs-metalogger , lizardfs-chunkserver , lizardfs-client , lizardfs-cgi , lizardfs-cgiserv , lizardfs-adm , lizardfs-debuginfo [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define liz_project mfs, %define liz_group %{liz_project}, %define liz_user %{liz_project}, %define liz_datadir %{_localstatedir}/lib/%{liz_project}, %define liz_confdir %{_sysconfdir}/%{liz_project} [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: lizardfs-master-3.10.6-3.fc26.x86_64.rpm lizardfs-metalogger-3.10.6-3.fc26.x86_64.rpm lizardfs-chunkserver-3.10.6-3.fc26.x86_64.rpm lizardfs-client-3.10.6-3.fc26.x86_64.rpm lizardfs-cgi-3.10.6-3.fc26.x86_64.rpm lizardfs-cgiserv-3.10.6-3.fc26.x86_64.rpm lizardfs-adm-3.10.6-3.fc26.x86_64.rpm lizardfs-debuginfo-3.10.6-3.fc26.x86_64.rpm lizardfs-3.10.6-3.fc26.src.rpm lizardfs-master.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/globaliolimits.cfg.dist lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsexports.cfg.dist lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsgoals.cfg.dist lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsmaster.cfg.dist lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfstopology.cfg.dist lizardfs-master.x86_64: W: non-standard-uid /var/lib/mfs mfs lizardfs-master.x86_64: W: non-standard-gid /var/lib/mfs mfs lizardfs-master.x86_64: W: non-standard-uid /var/lib/mfs/metadata.mfs.empty mfs lizardfs-master.x86_64: W: non-standard-gid /var/lib/mfs/metadata.mfs.empty mfs lizardfs-metalogger.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal lizardfs-metalogger.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsmetalogger.cfg.dist lizardfs-metalogger.x86_64: W: non-standard-uid /var/lib/mfs mfs lizardfs-metalogger.x86_64: W: non-standard-gid /var/lib/mfs mfs lizardfs-chunkserver.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfschunkserver.cfg.dist lizardfs-chunkserver.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfshdd.cfg.dist lizardfs-chunkserver.x86_64: W: non-standard-uid /var/lib/mfs mfs lizardfs-chunkserver.x86_64: W: non-standard-gid /var/lib/mfs mfs lizardfs-client.x86_64: W: conffile-without-noreplace-flag /etc/mfs/iolimits.cfg.dist lizardfs-client.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsmount.cfg.dist lizardfs-client.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/lizardfs lizardfs-client.x86_64: W: no-manual-page-for-binary mfsappendchunks lizardfs-client.x86_64: W: no-manual-page-for-binary mfscheckfile lizardfs-client.x86_64: W: no-manual-page-for-binary mfsdeleattr lizardfs-client.x86_64: W: no-manual-page-for-binary mfsdirinfo lizardfs-client.x86_64: W: no-manual-page-for-binary mfsfileinfo lizardfs-client.x86_64: W: no-manual-page-for-binary mfsfilerepair lizardfs-client.x86_64: W: no-manual-page-for-binary mfsgeteattr lizardfs-client.x86_64: W: no-manual-page-for-binary mfsgetgoal lizardfs-client.x86_64: W: no-manual-page-for-binary mfsgettrashtime lizardfs-client.x86_64: W: no-manual-page-for-binary mfsmakesnapshot lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrepquota lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrgetgoal lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrgettrashtime lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrsetgoal lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrsettrashtime lizardfs-client.x86_64: W: no-manual-page-for-binary mfsseteattr lizardfs-client.x86_64: W: no-manual-page-for-binary mfssetgoal lizardfs-client.x86_64: W: no-manual-page-for-binary mfssetquota lizardfs-client.x86_64: W: no-manual-page-for-binary mfssettrashtime lizardfs-client.x86_64: W: no-manual-page-for-binary mfssnapshot lizardfs-client.x86_64: W: no-manual-page-for-binary mfstools.sh lizardfs-cgi.x86_64: E: wrong-script-interpreter /usr/share/mfscgi/chart.cgi %{__python2} lizardfs-cgi.x86_64: E: wrong-script-interpreter /usr/share/mfscgi/mfs.cgi %{__python2} lizardfs-cgiserv.x86_64: E: wrong-script-interpreter /usr/sbin/lizardfs-cgiserver %{__python2} lizardfs-cgiserv.x86_64: E: wrong-script-interpreter /usr/sbin/mfscgiserv %{__python2} 9 packages and 0 specfiles checked; 4 errors, 42 warnings. Rpmlint (debuginfo) ------------------- Checking: lizardfs-debuginfo-3.10.6-3.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- lizardfs-cgi.x86_64: E: wrong-script-interpreter /usr/share/mfscgi/chart.cgi %{__python2} lizardfs-cgi.x86_64: E: wrong-script-interpreter /usr/share/mfscgi/mfs.cgi %{__python2} lizardfs-cgiserv.x86_64: E: wrong-script-interpreter /usr/sbin/lizardfs-cgiserver %{__python2} lizardfs-cgiserv.x86_64: E: wrong-script-interpreter /usr/sbin/mfscgiserv %{__python2} lizardfs-metalogger.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal lizardfs-metalogger.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsmetalogger.cfg.dist lizardfs-metalogger.x86_64: W: non-standard-uid /var/lib/mfs mfs lizardfs-metalogger.x86_64: W: non-standard-gid /var/lib/mfs mfs lizardfs-client.x86_64: W: conffile-without-noreplace-flag /etc/mfs/iolimits.cfg.dist lizardfs-client.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsmount.cfg.dist lizardfs-client.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/lizardfs lizardfs-client.x86_64: W: no-manual-page-for-binary mfsappendchunks lizardfs-client.x86_64: W: no-manual-page-for-binary mfscheckfile lizardfs-client.x86_64: W: no-manual-page-for-binary mfsdeleattr lizardfs-client.x86_64: W: no-manual-page-for-binary mfsdirinfo lizardfs-client.x86_64: W: no-manual-page-for-binary mfsfileinfo lizardfs-client.x86_64: W: no-manual-page-for-binary mfsfilerepair lizardfs-client.x86_64: W: no-manual-page-for-binary mfsgeteattr lizardfs-client.x86_64: W: no-manual-page-for-binary mfsgetgoal lizardfs-client.x86_64: W: no-manual-page-for-binary mfsgettrashtime lizardfs-client.x86_64: W: no-manual-page-for-binary mfsmakesnapshot lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrepquota lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrgetgoal lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrgettrashtime lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrsetgoal lizardfs-client.x86_64: W: no-manual-page-for-binary mfsrsettrashtime lizardfs-client.x86_64: W: no-manual-page-for-binary mfsseteattr lizardfs-client.x86_64: W: no-manual-page-for-binary mfssetgoal lizardfs-client.x86_64: W: no-manual-page-for-binary mfssetquota lizardfs-client.x86_64: W: no-manual-page-for-binary mfssettrashtime lizardfs-client.x86_64: W: no-manual-page-for-binary mfssnapshot lizardfs-client.x86_64: W: no-manual-page-for-binary mfstools.sh lizardfs-master.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/globaliolimits.cfg.dist lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsexports.cfg.dist lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsgoals.cfg.dist lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfsmaster.cfg.dist lizardfs-master.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfstopology.cfg.dist lizardfs-master.x86_64: W: non-standard-uid /var/lib/mfs mfs lizardfs-master.x86_64: W: non-standard-gid /var/lib/mfs mfs lizardfs-master.x86_64: W: non-standard-uid /var/lib/mfs/metadata.mfs.empty mfs lizardfs-master.x86_64: W: non-standard-gid /var/lib/mfs/metadata.mfs.empty mfs lizardfs-chunkserver.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfschunkserver.cfg.dist lizardfs-chunkserver.x86_64: W: conffile-without-noreplace-flag /etc/mfs/mfshdd.cfg.dist lizardfs-chunkserver.x86_64: W: non-standard-uid /var/lib/mfs mfs lizardfs-chunkserver.x86_64: W: non-standard-gid /var/lib/mfs mfs 8 packages and 0 specfiles checked; 4 errors, 42 warnings. Requires -------- lizardfs-cgi (rpmlib, GLIBC filtered): python lizardfs-cgiserv (rpmlib, GLIBC filtered): /bin/sh lizardfs-cgi systemd-units lizardfs-metalogger (rpmlib, GLIBC filtered): /bin/sh config(lizardfs-metalogger) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) systemd-units lizardfs-client (rpmlib, GLIBC filtered): /bin/bash config(lizardfs-client) fuse libc.so.6()(64bit) libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.4)(64bit) libfuse.so.2(FUSE_2.5)(64bit) libfuse.so.2(FUSE_2.6)(64bit) libfuse.so.2(FUSE_2.8)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) lizardfs-master (rpmlib, GLIBC filtered): /bin/bash /bin/sh config(lizardfs-master) libJudy.so.1()(64bit) libc.so.6()(64bit) libdb-5.3.so()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libz.so.1()(64bit) pam rtld(GNU_HASH) systemd-units lizardfs-debuginfo (rpmlib, GLIBC filtered): lizardfs-adm (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) lizardfs-chunkserver (rpmlib, GLIBC filtered): /bin/sh config(lizardfs-chunkserver) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) systemd-units Provides -------- lizardfs-cgi: lizardfs-cgi lizardfs-cgi(x86-64) lizardfs-cgiserv: lizardfs-cgiserv lizardfs-cgiserv(x86-64) lizardfs-metalogger: config(lizardfs-metalogger) lizardfs-metalogger lizardfs-metalogger(x86-64) lizardfs-client: config(lizardfs-client) lizardfs-client lizardfs-client(x86-64) lizardfs-master: config(lizardfs-master) lizardfs-master lizardfs-master(x86-64) lizardfs-debuginfo: lizardfs-debuginfo lizardfs-debuginfo(x86-64) lizardfs-adm: lizardfs-adm lizardfs-adm(x86-64) lizardfs-chunkserver: config(lizardfs-chunkserver) lizardfs-chunkserver lizardfs-chunkserver(x86-64) Source checksums ---------------- https://github.com/lizardfs/lizardfs/archive/v3.10.6/lizardfs-3.10.6.tar.gz : CHECKSUM(SHA256) this package : 8f6c19d8122d34a416929dc6ea0c424d2152b5301ad8c8a20b412bf1de27b67d CHECKSUM(SHA256) upstream package : 8f6c19d8122d34a416929dc6ea0c424d2152b5301ad8c8a20b412bf1de27b67d Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1441729 Buildroot used: fedora-26-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx