[Bug 1427182] Review Request: libzypp - A package management library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1427182

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Summary should probably mention that this is suse-related. Maybe something
> like "Summary: Package management library used by OpenSUSE and ...".
Not a requirement, but I still think it'd be a good idea.

> libzypp-devel-doc.noarch: E: devel-dependency libzypp-devel
> Is this dep necessary?
libzypp-devel-doc contains only html pages. It should be OK to drop this
dependency
(and add %doc %dir /usr/share/doc/libzypp).

[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/doc/libzypp
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/doc/libzypp,
     /etc/logrotate.d, /usr/libexec/zypp

zypp-tools.x86_64: E: non-executable-script /usr/libexec/zypp/notify-message
644 /bin/bash 

Copying from previous comments:
+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ scriptlets appear correct
+ builds and installs OK
+ latest version
+ R/P/BR appear correct
and continuing
+ %check is present and passes

fedora-review finds no other issues.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]