https://bugzilla.redhat.com/show_bug.cgi?id=1427185 --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > # Use correct libexecdir > find -type f -exec sed -i -e "s|/usr/lib/zypper|%{_libexecdir}/zypper|g" {} ';' > find -type f -exec sed -i -e "s|\${CMAKE_INSTALL_PREFIX}/lib/zypper|\${CMAKE_INSTALL_PREFIX}/libexec/zypper|g" {} ';' > find -type f -exec sed -i -e "s|\${CMAKE_INSTALL_PREFIX}/lib/\${PACKAGE}|\${CMAKE_INSTALL_PREFIX}/libexec/\${PACKAGE}|g" {} ';' That's nothing better about %_libexecdir/zypper compared to %_lib/zypper. Those two directories are on the same partition always, FHS says both are OK. IMHO %_libexecdir is just cargo-culting of a non-solution to a non-problem. One could even argue that this change is in violation of Fedora guidelines, because it's a divergence from upstream without a reason. It's your choice, but fwiw, I think you're doing it wrong ;) > # Fix shebang for zypper-log > sed -e "s|/usr/bin/env python|/usr/bin/python|g" -i %{buildroot}%{_sbindir}/zypper-log Does it support python3? If yes, it would be better to use /usr/bin/python3 instead. Ah, OK, it doesn't. Looking at the code made my eyes bleed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/zypper, /etc/logrotate.d, /etc/zypp > %{_sysconfdir}/bash_completion.d/zypper.sh Please move that to %{_datadir}/bash-completion/completions/. zypp-apt-get is a symlink to "aptitude". When you rename aptidue to zypp-aptitude, you need to update the symlink too. zypp-aptitude is a perl program. You need build deps [http://fedoraproject.org/wiki/Packaging:Perl#Build_Dependencies] and Requires [http://fedoraproject.org/wiki/Packaging:Perl#Versioned_MODULE_COMPAT_Requires]. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx