https://bugzilla.redhat.com/show_bug.cgi?id=1434003 --- Comment #7 from Kalev Lember <klember@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #6) > Created attachment 1264822 [details] > licensecheck output for tilix > > Some issues encountered by fedora-review: > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "GPL (v2 or later)", "GPL (v3 or later)", "*No copyright* CC > by-sa (v3.0)", "Unknown or generated", "*No copyright* MPL (v2.0)", > "MPL (v2.0)". 126 files have unknown license. Detailed output of > licensecheck in /home/makerpm/1434003-tilix/licensecheck.txt > > Please verify with upstream that the licensing is sane. licensecheck output > attached to this bug. Thanks. I've updated the licensing breakdown, which now reads: # The tilix source code is MPLv2.0, # source/gx/gtk/x11.d is GPLv2+, # source/secret is LGPLv3+, # source/x11 and com.gexperts.Tilix.gschema.xml are GPLv3+, # icons are CC-BY-SA. # This makes the combined license: License: MPLv2.0 and GPLv3+ and CC-BY-SA > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/metainfo > > Until we migrate from /usr/share/appdata to /usr/share/metainfo completely > (tooling, dependency generators, etc.), please move metainfo/appdata files > to /usr/share/appdata. Putting appdata files in that directory is completely fine. I just recently fixed the appstream generator to work with /usr/share/metainfo. As for the directory ownership, this belongs to the filesystem package. I've already filed a filesystem ticket earlier today to add it, https://bugzilla.redhat.com/show_bug.cgi?id=1434008 > [!]: Package must own all directories that it creates. > Note: Directories without known owners: > /usr/share/icons/hicolor/22x22/apps, > /usr/share/icons/hicolor/32x32/apps, /usr/share/metainfo, > /usr/share/dbus-1/services, /usr/share/icons/hicolor/24x24, > /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16, > /usr/share/icons/hicolor/48x48/apps, > /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, > /usr/share/icons/hicolor/24x24/apps, /usr/share/dbus-1, > /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32, > /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22, > /usr/share/glib-2.0, /usr/share/icons/hicolor/512x512, > /usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/48x48, > /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable > > The hicolor dir ownership can be fixed with Req on hicolor-icon-theme. The > dbus dir ownership can be fixed with Req on dbus, I believe. The glib-2.0 > dirs issue can probably be fixed by Req glib2, though that should be > happening already... Thanks, I've added explicit dbus and hicolor-icon-theme deps. glib2 is definitely pulled in via dependencies and there's no need to add it. * Mon Mar 20 2017 Kalev Lember <klember@xxxxxxxxxx> - 1.5.4-3 - Update licensing breakdown (#1434003) - Add explicit dbus and hicolor-icon-theme deps for directory ownership Spec URL: https://kalev.fedorapeople.org/tilix.spec SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-3.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx