[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #6 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Created attachment 1264822
  --> https://bugzilla.redhat.com/attachment.cgi?id=1264822&action=edit
licensecheck output for tilix

Some issues encountered by fedora-review:

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "GPL (v3 or later)", "*No copyright* CC
     by-sa (v3.0)", "Unknown or generated", "*No copyright* MPL (v2.0)",
     "MPL (v2.0)". 126 files have unknown license. Detailed output of
     licensecheck in /home/makerpm/1434003-tilix/licensecheck.txt

Please verify with upstream that the licensing is sane. licensecheck output
attached to this bug.

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/metainfo

Until we migrate from /usr/share/appdata to /usr/share/metainfo completely
(tooling, dependency generators, etc.), please move metainfo/appdata files to
/usr/share/appdata.

[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/22x22/apps,
     /usr/share/icons/hicolor/32x32/apps, /usr/share/metainfo,
     /usr/share/dbus-1/services, /usr/share/icons/hicolor/24x24,
     /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16,
     /usr/share/icons/hicolor/48x48/apps,
     /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/24x24/apps, /usr/share/dbus-1,
     /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32,
     /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22,
     /usr/share/glib-2.0, /usr/share/icons/hicolor/512x512,
     /usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/48x48,
     /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable

The hicolor dir ownership can be fixed with Req on hicolor-icon-theme. The dbus
dir ownership can be fixed with Req on dbus, I believe. The glib-2.0 dirs issue
can probably be fixed by Req glib2, though that should be happening already...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]