https://bugzilla.redhat.com/show_bug.cgi?id=1388945 --- Comment #16 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> --- (In reply to Andrew Toskin from comment #15) > Okay, sorry, NOW I think think there's just one last issue -- managing > gschemas -- with a couple subpoints. > > > ## Compiling the gsettings schemas > > According to this section of the Packaging wiki > <https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging: > ScriptletSnippets#GSettings_Schema>, you shouldn't need to compile the > gschemas yourself anymore. Bug #1409315 is an open thread about removing the > post-transaction schema compilation rule from fedora-review. > > This is just FYI. I think you may choose to keep the transaction scriptlets > for now, if you wish to avoid the glib warnings from fedora-review, at least > until fedora-review gets updated. But unless I'm missing some information > here, the scriptlet will be removed in the future. keept the transaction scriptlets for now, as you mentioned. > ## Dependencies > > "BuildRequires: glib2-devel" is needed because the source configure script > includes "GLIB_GSETTINGS". This part seems a little obscure to me, but I'm > guessing it's used for compiling gschemas. Upstream probably needs this for > users who will only install this extension to their home directory. (You'll > also need to (Build)Require glib2 for compiling schemas in the > post-transaction scriptlet, but as noted above, that's on its way out.) So > unless upstream were interested in figuring out how to make that part > optional, you will need to keep the BuildRequire. > > However, "Requires: glib2" is definitely not needed. This is why rpmlint > returns the error "explicit-lib-dependency glib2". RPM already detects this > dependency for you. I don't personally think slightly overstatin%changelog * Tue Mar 14 2017 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0-0.8.20170314git61d9118 - Update to new git snapshot 0.1-0.8.20170314git61d9118 - Remove RR glib2g the > dependencies here should be a big deal, but rpmlint marks this as an *error* > rather than a warning, so I really do think you should remove it. glib2 removed > > Once this last minor issue is resolved, I'll approve the package :) Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/gnome-shell-extension-media-player-indicator.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/gnome-shell-extension-media-player-indicator-0-0.8.20170314git61d9118.fc25.src.rpm %changelog * Tue Mar 14 2017 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0-0.8.20170314git61d9118 - Update to new git snapshot 0.1-0.8.20170314git61d9118 - Remove RR glib2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx