[Bug 1388945] Review Request: gnome-shell-extension-media-player-indicator - Control MPRIS2 capable media players : Rhythmbox, Banshee, Clementine and more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1388945



--- Comment #15 from Andrew Toskin <andrew@xxxxxxx> ---
Okay, sorry, NOW I think think there's just one last issue -- managing gschemas
-- with a couple subpoints.


## Compiling the gsettings schemas

According to this section of the Packaging wiki
<https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#GSettings_Schema>,
you shouldn't need to compile the gschemas yourself anymore. Bug #1409315 is an
open thread about removing the post-transaction schema compilation rule from
fedora-review.

This is just FYI. I think you may choose to keep the transaction scriptlets for
now, if you wish to avoid the glib warnings from fedora-review, at least until
fedora-review gets updated. But unless I'm missing some information here, the
scriptlet will be removed in the future.


## Dependencies

"BuildRequires: glib2-devel" is needed because the source configure script
includes "GLIB_GSETTINGS". This part seems a little obscure to me, but I'm
guessing it's used for compiling gschemas. Upstream probably needs this for
users who will only install this extension to their home directory. (You'll
also need to (Build)Require glib2 for compiling schemas in the post-transaction
scriptlet, but as noted above, that's on its way out.) So unless upstream were
interested in figuring out how to make that part optional, you will need to
keep the BuildRequire.

However, "Requires: glib2" is definitely not needed. This is why rpmlint
returns the error "explicit-lib-dependency glib2". RPM already detects this
dependency for you. I don't personally think slightly overstating the
dependencies here should be a big deal, but rpmlint marks this as an *error*
rather than a warning, so I really do think you should remove it.


Once this last minor issue is resolved, I'll approve the package :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]