https://bugzilla.redhat.com/show_bug.cgi?id=1422683 --- Comment #2 from Tom Hughes <tom@xxxxxxxxxx> --- What do we need to do to get this sorted? ideally we need to get this back in for F26 so we can update asterisk... It looks like there are three issues in the review output: * Build dependencies * License breakdown * Need to require udev (or own udev rules directory) * Rename requires correct obsoletes etc * Use of %define I don't understand the build dependency issue - the linked page doesn't seem to be relevant and things like gcc are actually supposed to be required now. Equally this isn't a rename so that point doesn't seem to be relevant? Fixing the %defines is presumably easy. So if the license breakdown the main issue? I don't recall seeing that requirement before - are we really expected to write a big list of which source files are under which license and embed it in the spec? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx