https://bugzilla.redhat.com/show_bug.cgi?id=1431445 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- This information (both pieces) should be added as comments in the spec file. The description of licensing breakdown is required by the guidelines [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios]. + license is acceptable (MIT, BSD 3-clause) + license is specified correctly, but see note above + package name is OK (upstream uses 'avogadrolibs', but avogadro2-libs matches better with avogadro2, so it's better) + builds and installs OK + fedora-review has no complaints + jsoncpp.a: Provides: jsoncpp-static is declared, the library is in a private directory + P/R/BR look correct - scriptlets are missing: https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries rpmlint: avogadro2-libs.src: W: spelling-error %description -l en_US bioinformatics -> misinformation, information avogadro2-libs.x86_64: W: spelling-error %description -l en_US bioinformatics -> misinformation, information Bogus. avogadro2-libs.src:28: W: unversioned-explicit-provides jsoncpp-static Please provide the version (e.g. " = XXXXYYZZ") if possible. avogadro2-libs.x86_64: E: invalid-soname /usr/lib64/libAvogadroIO.so libAvogadroIO.so ... avogadro2-libs.x86_64: E: invalid-soname /usr/lib64/libAvogadroQtPlugins.so libAvogadroQtPlugins.so I *think* that's OK. avogadro2-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libAvogadroQtPlugins.so exit@GLIBC_2.2.5 Dunno. avogadro2-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/avogadro2/staticplugins/Spectra.a ... avogadro2-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/avogadro2/staticplugins/NetworkDatabases.a avogadro2-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/avogadro2/libjsoncpp.a Those are plugins, so OK. avogadro2-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id avogadro2-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id Known bug in rpmlint [https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo]. avogadro2-libs-devel.x86_64: W: only-non-binary-in-usr-lib avogadro2-libs-devel.x86_64: W: no-documentation OK. 5 packages and 0 specfiles checked; 8 errors, 46 warnings. Package is APPROVED. Please add the two comments and version tag (if possible) and scriptlets when uploading. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx