Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadPassword - Asking the user for a password https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248407 rpm@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From rpm@xxxxxxxxxxxxxx 2007-07-24 17:07 EST ------- MUST items: 1. rpmlint is quiet 2. package named properly 3. spec filename matches package name 4. meets packaging guidelines 5. open source license 6. license field matches actual license 7. specfile written in AmE 8. specfile is legible 9. sources match upstream: cc1a611fbb6dfd4d6e96e54434bb20b8 Term-ReadPassword-0.07.tar.gz 10. builds properly on devel/x86_64 11. no ExcludeArch necessary 12. proper BuildRequires 13. doesn't have locales 14. no shared libraries 15. not relocatable 16. owns all directories it creates 17. no duplicates in %files 18. proper file permissions 19. proper %clean section 20. consistent macro usage 21. code, not content 22. no large docs 23. %doc not necessary for runtime operation 24. no headers 25. no static libs 26. no pkgconfig files 27. no libraries with suffix 28. no devel subpackage 29. no .la files 30. no GUI 31. owns directories owned by other packages: perl-Term-ProgressBar, perl-Term-UI -> we don't have any package owning %{perl_vendorlib}/Term, though, so this is OK. 32. cleans buildroot in %install 33. filenames are valid UTF-8 SHOULD items: 1. source package doesn't include any license file, please ask upstream to include it 2. no translations of summary/description available 3. builds in mock/devel/x86_64 4. noarch package 5. software works as intended 6. no scriptlets used 7. no subpackages 8. no pkgconfig files 9. no file dependencies APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review