https://bugzilla.redhat.com/show_bug.cgi?id=1428760 --- Comment #2 from clime@xxxxxxxxxx --- (In reply to Miroslav Suchý from comment #1) > > Group: Applications/Productivity > > This is no longer used. And it is not needed unless you target EL5. > Please remove it. Done. > > After groupadd you should add exit 0. See > https://fedoraproject.org/wiki/Packaging: > UsersAndGroups#Rationale_for_some_of_the_implementation_choices Done. > > > # /usr/local/bin ........... scripts > The path has been changed obviously. > Done. > Can you call restorecon only if the policy has been changed? Restorecon is called only on dirs themselves. It's not recursive except for web dir with the single script file upload.cgi. We don't need to further optimize, I think. > > >%defattr(-,root,root,0755) > This is the default. No need to write it here. Yeah, but it's nice to be explicit in some cases. > > > You are missing systemd post and pre scripts: > https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging: > ScriptletSnippets#Systemd Added. > > > %global selinux_policyver %(%{__sed} -e 's,.*selinux-policy-\\([^/]*\\)/.*,\\1,' /usr/share/selinux/devel/policyhelp || echo 0.0.0) > This will print error when selinux-policy-doc is not installed. > You should add > BuildRequires: /usr/share/selinux/devel/policyhelp Added. Updated according to review: srpm: http://clime.cz/dist-git-0.13-1.git.60.591bd54.fc24.src.rpm spec: http://clime.cz/dist-git.spec I am thinking about dropping epel6 support for simplification, although it would be very nice to have it. BuildRequire: /usr/share/selinux/devel/policyhelp seems to be a bit clumsy and I get some sed warnings when building srpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx