https://bugzilla.redhat.com/show_bug.cgi?id=1428760 --- Comment #1 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > Group: Applications/Productivity This is no longer used. And it is not needed unless you target EL5. Please remove it. After groupadd you should add exit 0. See https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Rationale_for_some_of_the_implementation_choices > # /usr/local/bin ........... scripts The path has been changed obviously. Can you call restorecon only if the policy has been changed? >%defattr(-,root,root,0755) This is the default. No need to write it here. You are missing systemd post and pre scripts: https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd > %global selinux_policyver %(%{__sed} -e 's,.*selinux-policy-\\([^/]*\\)/.*,\\1,' /usr/share/selinux/devel/policyhelp || echo 0.0.0) This will print error when selinux-policy-doc is not installed. You should add BuildRequires: /usr/share/selinux/devel/policyhelp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx