[Bug 1132661] Review Request: atom - Atom editor from github

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1132661



--- Comment #35 from Raphael Groner <projects.rg@xxxxxxxx> ---
Hi Dominik,
you can open a new package review request and close this one as a duplication.
Your FAS seems to be inder, this user is currently not in the packager group.
That means you first need to get sponsored as a packager.
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored

##
Now some general advice to your spec file:

- Where did you download the source tarball? You have to provide a valid URL or
at least explain (by comment) how to create the tarball.
> Source: %{name}-%{version}.tar.xz
https://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source
https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code

- You can expect implicit dependencies of gcc-c++ or the general build
environment and do not need to list them explicitly:
> BuildRequires: make
> BuildRequires: gcc
> BuildRequires: glibc-devel
> BuildRequires: rpmdevtools

- %description line is too long, insert a line break after 'core—a tool'
  to split into two lines.

- Please set all %global at the beginning of the file.

- Please use 'cp -p' to preserve timestamps.
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

- Please provide a link to the raw spec file to let fedora-review tool properly
download:
https://gist.githubusercontent.com/I-n-d-e-r/fa7f3322e08df951b584336a886dea7e/raw/bbb5dffa6cff7f5e380a8b0f0ddc86835e7692e0/atom.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]