https://bugzilla.redhat.com/show_bug.cgi?id=1333928 VincentS <vincent@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vincent@xxxxxxxxxxxxxxxxxx --- Comment #5 from VincentS <vincent@xxxxxxxxxxxxxxxxxx> --- Hello, I'm not a reviewer but I have some comments on your review request. First of all, there is a line too long in description. $ rpmlint python-searchlightclient-0.2.1-1.fc25.src.rpm python-searchlightclient.src: E: description-line-too-long C This is a client library for Searchlight built on the Searchlight API. It provides a Python API (the searchlightclient module) and a osc plugin for openstackclient CLI. Then, I think you should use macros like that: %global client python-searchlightclient ^^ Should be %global client searchlightclient and %global sclient searchlightclient ^^ delete this line which is useless then Name: %{client} ^^ should be python-%{client} For more details and if you want do others review requests of python software, you should see https://fedoraproject.org/wiki/Packaging:Python You could also use macro for summary to avoid repetitions. Summary: OpenStack Indexing and Search API Client Library ^^ Moreover, sources seems to be different from upstream. $ sha256sum -b python-searchlightclient-0.2.1.tar.gz rpmbuild/SOURCES/python-searchlightclient-0.2.1.tar.gz 16494d6d9441b43ea77e65dee7c6423631198cadc24068c59f5947a6a37d2e70 *python-searchlightclient-0.2.1.tar.gz 97a39ed792d3535740a91c71d9b22b198a07fdaf5ccb32043b8a09f8a21c1fd7 *rpmbuild/SOURCES/python-searchlightclient-0.2.1.tar.gz Why do you add these dependancies ? BuildRequires: python-setuptools BuildRequires: git BuildRequires: python-hacking >= 0.10.2 BuildRequires: python-coverage >= 3.6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx