https://bugzilla.redhat.com/show_bug.cgi?id=1428974 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal) Flags|needinfo?(dlabsky@xxxxxxxxx | |m) | --- Comment #8 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to David "Sanqui" Labský from comment #7) > >Adding an explanation comment (Such as "See LICENSE for details") would be nice. > Where would this be? I'm under the impression the License tag should be > machine-readable. I meant a # comment above the License tag. > >Why is the debuginfo package disabled? > I am getting the following error when I enable debuginfo: > > error: Empty %files file /builddir/build/BUILD/rgbds-0.2.4/debugfiles.list > Empty %files file /builddir/build/BUILD/rgbds-0.2.4/debugfiles.list > > I'm assuming the build process isn't producing sufficient debug information. > I'll be looking into it further. Try setting the compiler flags https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > >As I understand it, this allows you to create games for the Game Boy? That should be fine. Does it contain any binary blobs or such that might be problematic? > Games and utilities, correct. I am aware the rgbfix utility contains a > small bitmap of the Nintendo logo[0]. > > This bitmap must be present in the ROM in order for the console to boot into > the game. It is my understanding the presence of the logo, when it's > required to pass hardware restrictions, is not a trademark violation, > rather, it deemed fair use in the US (see [1]), but IANAL. > > [0] https://github.com/rednex/rgbds/blob/v0.2.4/src/fix/main.c#L212 > [1] https://en.wikipedia.org/wiki/Sega_v._Accolade I'm not capable of deciding that. Setting to block FE-Legal and will ask on the mailing list. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx