https://bugzilla.redhat.com/show_bug.cgi?id=1428974 --- Comment #7 from David "Sanqui" Labský <dlabsky@xxxxxxxxxx> --- >The License tag says: DWPL and ISC and MIT >From reading the LICENSE [0], I'd say it shall be: DWPL and ISC and MIT and BSD I will correct this, good catch. >Adding an explanation comment (Such as "See LICENSE for details") would be nice. Where would this be? I'm under the impression the License tag should be machine-readable. >I'd suggest you remove the commented out "#Requires: ". OK >Also, the Q=(nothing) in %build is confusing, maybe change it to Q=""? OK >Why is the debuginfo package disabled? I am getting the following error when I enable debuginfo: error: Empty %files file /builddir/build/BUILD/rgbds-0.2.4/debugfiles.list Empty %files file /builddir/build/BUILD/rgbds-0.2.4/debugfiles.list I'm assuming the build process isn't producing sufficient debug information. I'll be looking into it further. >I'm curious whether this belongs to: >https://fedoraproject.org/wiki/Packaging:Guidelines#Packages_which_are_not_useful_without_external_bits >Also, is this an emulator? It is not an emulator. This software is an assembler package - it transforms source code into binaries. It can be used to build free software for the game console, and indeed such software can be found on the internet. Therefore, it does not have non-free dependencies. >The description says "for the Game Boy and Game Boy Color" and that s fine. >However the summary simply says "A Game Boy development package, including an assembler" and that may not be OK. What about "A development package for Game Boy, including an assembler"? Agreed, I shall change it. >As I understand it, this allows you to create games for the Game Boy? That should be fine. Does it contain any binary blobs or such that might be problematic? Games and utilities, correct. I am aware the rgbfix utility contains a small bitmap of the Nintendo logo[0]. This bitmap must be present in the ROM in order for the console to boot into the game. It is my understanding the presence of the logo, when it's required to pass hardware restrictions, is not a trademark violation, rather, it deemed fair use in the US (see [1]), but IANAL. >I'd suggest to add the following section fo the README to the description as well: I'll add it. Note that rgbgfx is not provided by the version I am packaging (0.2.4). [0] https://github.com/rednex/rgbds/blob/v0.2.4/src/fix/main.c#L212 [1] https://en.wikipedia.org/wiki/Sega_v._Accolade -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx