https://bugzilla.redhat.com/show_bug.cgi?id=1427341 --- Comment #1 from Charalampos Stratakis <cstratak@xxxxxxxxxx> --- Some initial comments: You should get rid of the macros on top of the SPEC file as these are required only for EPEL. You should make consistent use of macros so URL should be in the form of: https://github.com/hsnr-%{srcname}/%{srcname} and the Source0 url in a similar fashion (don't forget the %{version} macro) For the '%{__python2} setup.py build' there is already a macro that you can use: '%py2_build' If the c++ sources need to be removed (what is the reason?) they should be removed during prep and not after compiling them. Also it seems that upstream there is no activity for 3 months now and the requirements for the project seems quite low, are you sure that gamera is compatible with the latest versions of its requirements (e.g. in Fedora rawhide we have now gcc 7)? On another note please read the Fedora Python Packaging Guidelines [0] for more info on how to structure these kind of SPEC files. [0] https://fedoraproject.org/wiki/Packaging:Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx