https://bugzilla.redhat.com/show_bug.cgi?id=1428513 Jan Chaloupka <jchaloup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jchaloup@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jchaloup@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- You can always keep the unit-test-devel subpackage and just set with_unit_test to 0. The tests can appear in future and it is much more easier to just set with_unit_test to 1 instead of putting back the entire subpackage. At the same time I always keep the Source0: https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz in a form of Source0: https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz You will always get the same tarball as long as the commit corresponds to version. At the same time it is easier to update to non-versioned commit. None of it is a blocker for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx