https://bugzilla.redhat.com/show_bug.cgi?id=1427634 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- 1) I replaced EA tags with the appropriate ones. 2) I put in %commit and %shortcommit that match the release tag. 3 + 4) I'll adapt the *syncthing.spec file contents generated by gofed and include the missing BRs and Reqs. There's two more question from my side: i) gofed generates quite a long list of BR's and Requires, but all of those are bundled in the upstream tarball (and not all of them are in fedora yet). Should I strip the "vendored" / bundled libraries before %build? (I know fedora doesn't like bundled stuff ...) If so, I'll probably have to open review requests for the packages missing from fedora, and BR: those packages. ii) I think I should include the following Provides to match the usual naming scheme for golang packages. Is that a good idea? - syncthing provides golang-github-syncthing-syncthing, - syncthing-devel provides - golang-github-syncthing-syncthing-devel and - golang(github.com/syncthing/syncthing) - syncthing-unit-test-devel provides - golang-github-syncthing-syncthing-unit-test-devel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx