https://bugzilla.redhat.com/show_bug.cgi?id=1427634 Jan Chaloupka <jchaloup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jchaloup@redhat.c | |om) | --- Comment #3 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- 1) Missing: # e.g. el6 has ppc64 arch without gcc-go, so EA tag is required ExclusiveArch: %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64 %{arm}} # If go_compiler is not set to 1, there is no virtual provide. Use golang instead. BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang} It is not required, it just helps to build your spec file on various architectures. The go_arches is not defined on el6 and epel7 so the build will fail there 2) Missing %commit macro. Though it is not needed to build the rpms, it is used by gofed tooling to associate your spec file with upstream repository (e.g. to run periodic checks, to bump the spec file, ...) %global commit 204f125ab33eb5f4595343940db343ffb01108ee 3) Missing BuildRequires in the devel subpackage. Without the BuildRequires you can not run tests. Though the BR are part of the main package, they are needed in the devel subpackage as well. 4) Missing unit-test-devel subpackage. Even if the tests are not run, it is always good to provide the test. So some tooling can run CI tests over all go packages one day and collect important data for upstream feedback. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx