[Bug 1425934] Review Request: python-mtg - Console-based access to the Gatherer Magic Card Database

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1425934



--- Comment #2 from Ben Rosser <rosser.bjr@xxxxxxxxx> ---
Thanks for taking the review!

My bad; it did not even occur to me that we couldn't ship tests/_data. It seems
that 43 of the 142 tests need that content [1] in order to run. All the failing
tests are in card_extractor_test.py, but there are also some tests in there
that succeed. 

As a short term solution, I could simply get rid of card_extractor_test.py; as
a long term solution I could try to get upstream to split card_extractor_test
into tests that do require data_ and tests that don't.

If that seems like a reasonable course of action, I'll remove data_ from the
tarball, rebuild the SRPM, and get rid of card_extractor_test.py in %prep.

[1]
https://paste.fedoraproject.org/paste/nvzygVUtxGq4p-MgEYqelF5M1UNdIGYhyRLivL9gydE=/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]