https://bugzilla.redhat.com/show_bug.cgi?id=1425934 --- Comment #1 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi Ben, I am taking this review! I don't think we need a python 2 binary nor have them versioned as mtg-X-Y. See [1] for reference. There are no egg.info directories in the package, so there's no need to remove one in %prep About adding the Provides: mtg, we can see in [2] that this is up to you :) Finally, do you have any comments on the content in 'tests/_data'? It seems that upstream copied some pages from Wizards of the Coast with some real Magic: The Gathering card descriptions. I am not sure if we can ship that, even if it is in a source package. I would be comfortable with either - raising FE-LEGAL flag to make sure this content is allowed - removing the tests from the tarball :( - removing the _data subdir from the tests and skipping the tests that need it [1] https://fedoraproject.org/wiki/Packaging:Python#Avoiding_collisions_between_the_python_2_and_python_3_stacks [2] https://fedoraproject.org/wiki/User:Tibbs/AppVsLib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx