[Bug 1419226] Review Request: prelude-correlator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1419226



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
s/SystemD/systemd/

+ package name is OK
+ license is acceptable (GPLv2)
- license is specified correctly:
  not, it's GPLv2+, see the headers in the files

Why /etc/prelude-correlator/rules? That python code does not look like
something that is configurable, wouldn't it be better to put it somewhere in
/usr/?

Does the binary fork anything? If there's just one process, you can do away
with the pid file, which would obviate the need for a directory in /run and
simplify things.

Could this daemon run as a normal user? What kind of privileges does is
require?

Hm, why do the python subpackage require prelude-correlator.rpm?
prelude-correlator includes a service file which will not work without
python3-p-c, so it seems prelude-correlator.rpm should require
python3-prelude-correlator. I'm pretty sure that 'dnf install
prelude-correlator' should yield a working setup.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]