[Bug 1419226] Review Request: prelude-correlator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1419226



--- Comment #2 from Thomas Andrejak <thomas.andrejak@xxxxxxxxx> ---
Hello,

Here are the new files :
SPEC : https://fedorapeople.org/~totol/prelude-correlator.spec
SRPM : https://fedorapeople.org/~totol/prelude-correlator-3.1.0-1.fc26.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> No python 3 support? Please note that python3 support MUST be enabled if
> possible.

=> I had a patch to have it :)

> 
> "install init script" → not to be picky, but it's neither init nor a script
> ;)

Done

> 
> In one place you use install -D, in others the directories are created by
> hand.

Done

> 
> It looks all good, only cosmetic issues, apart from the one big question —
> python3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]