https://bugzilla.redhat.com/show_bug.cgi?id=1419122 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |negativo17@xxxxxxxxx --- Comment #11 from Simone Caronni <negativo17@xxxxxxxxx> --- Hi Sasha, just a couple of notes. (In reply to Sascha Spreitzer from comment #3) > As I am using fedora-review it is better I am pasting the plain/raw link > version of the spec link here for automatic processing. > > Spec URL: > http://git.scrit.ch/srpm/rubygem-base32/plain/SPECS/rubygem-base32.spec > SRPM URL: > https://kojipkgs.fedoraproject.org//work/tasks/380/17570380/rubygem-base32-0. > 3.2-1.fc26.src.rpm fedora-review is "smart enough" to actually get the links in the last comment in which they are available, you don't need to make sure they are in the last comment before the actual fedora-review process. (In reply to Sascha Spreitzer from comment #8) > Must: > ! license file in all packages Actually you need to make sure that the license is available in any package installation combination. So judging by a quick look from the spec file, the -doc subpackage requires the main package to be installed, so the license is enough to be available in the main package as it is always installed when -doc is. PS: I'm not watching you, but when you sponsor someone you are notified of the Bugzilla actions of the person you've sponsored :P -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx