https://bugzilla.redhat.com/show_bug.cgi?id=1417316 Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> --- Review: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Requires correct, justified where necessary. Requires -------- perl-IO-Socket-Multicast-debuginfo (rpmlib, GLIBC filtered): perl-IO-Socket-Multicast (rpmlib, GLIBC filtered): libc.so.6()(64bit) libperl.so.5.24()(64bit) perl(:MODULE_COMPAT_5.24.1) perl(:VERSION) perl(Carp) perl(DynaLoader) perl(Exporter) perl(IO::Interface) perl(IO::Socket) perl(strict) perl(vars) rtld(GNU_HASH) Provides -------- perl-IO-Socket-Multicast-debuginfo: perl-IO-Socket-Multicast-debuginfo perl-IO-Socket-Multicast-debuginfo(x86-64) perl-IO-Socket-Multicast: perl(IO::Socket::Multicast) perl-IO-Socket-Multicast perl-IO-Socket-Multicast(x86-64) [x]: Spec file is legible and written in American English. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. https://koji.fedoraproject.org/koji/taskinfo?taskID=17631726 [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. Source checksums ---------------- http://www.cpan.org/authors/id/B/BR/BRAMBLE/IO-Socket-Multicast-1.12.tar.gz : CHECKSUM(SHA256) this package : 70e8af4aa21d19bab5edd9f43a6b3d6277748a65145d46ff0ea2ae4c59495c72 CHECKSUM(SHA256) upstream package : 70e8af4aa21d19bab5edd9f43a6b3d6277748a65145d46ff0ea2ae4c59495c72 http://dev.perl.org/licenses/#/perl-IO-Socket-Multicast-Licensing.html : CHECKSUM(SHA256) this package : 72bf15c36e662c7a6d759bcc98f0041d63e0f4695f852b67e84ec9ca63745899 CHECKSUM(SHA256) upstream package : 72bf15c36e662c7a6d759bcc98f0041d63e0f4695f852b67e84ec9ca63745899 [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. Package Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx